[platform-swt-dev] Fw: [platform-ui-dev] CodeMining and bugs to fix

[Daniel Megert]

Forwarding to SWT list as most issues are there.

Dani

----- Forwarded by Daniel Megert/Zurich/IBM on 19.06.2018 15:50 -----

From: Angelo zerr <***@gmail.com>
To: "Eclipse Platform UI component developers list."
<platform-ui-***@eclipse.org>
Date: 19.06.2018 10:22
Subject: [platform-ui-dev] CodeMining and bugs to fix
Sent by: platform-ui-dev-***@eclipse.org



Hi all,

Eclipse Photon provides now CodeMining feature, it works well (according
feedback that I have with JDT CodeMining) but it is not perfect, several
bugs was created and all thoses bugs concern several issues:

* 1) MacOS renderer is bad. Hope https://git.eclipse.org/r/#/c/123367/
will be merged.
* 2) redraw of character where GlyphMetrics is added (to takes place)
causes some problem, See issue
https://bugs.eclipse.org/bugs/show_bug.cgi?id=531769

This redraw character issue provides problem when you try to select the
character (you cannot), when character is selected, it is not well
colorized, etc.

Here some bugs:

* https://github.com/angelozerr/jdt-codemining/issues/10
* https://github.com/angelozerr/jdt-codemining/issues/40

IMHO I think this bug is important, but it requires changed of TextLayout
for each OS. I have done a quick gerrit patch for Windows OS, but I need
to test the behaviour with inlined annotation. As it's an hard issue, I'm
waiting for to check that there will have a chance that some people will
work on this issue (Karsten has started to study thi sissue for MacOS, but
what about with Linux OS?)

If I'm sure that we will have an implementation for each TextLayout OS, I
will work to avoid redrawing the character where Glyphmetrics is added and
it will fix a lot of issues.

* 3) Line Text height. I think more and more we should have a StyledText
#getLineTextHeight(int line) to retrieve the line text height (in other
words the line height - the inlined annotation line header height

Here some bugs

* https://github.com/angelozerr/jdt-codemining/issues/6:
* https://github.com/angelozerr/jdt-codemining/issues/32

@Mickael is there any chance that we could work together on this issue?

* 4) refactor bug

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=532832


Regard's Angelo_______________________________________________
platform-ui-dev mailing list
platform-ui-***@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev